Thrift metrics: omit status codes for exceptions with a non-int code #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbrae
force-pushed
the
cd-grpc-thrift-interop-code
branch
from
20a679d
to
de6a317
Compare
|
@chriskuehl for some context there were the labels we were getting due to the fact that |
chriskuehl
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
If an exception has a
codeproperty that is not actually derived from a baseplate ErrorCode, we currently muddy our prometheus labels with invalid values. This goes a step further to reduce the risk of this occurring by checking for integers, whichErrorCode's thrift definition would require.📜 Details
Context available in this thread for employees: https://reddit.slack.com/archives/C070ARBL3M2/p1713888048834589
🧪 Testing Steps / Validation
Unit tested
✅ Checks