New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update args for repl.start() #38

Merged

redguardtoo merged 2 commits into redguardtoo:master from joshbax189:fix/update-node-args

Nov 7, 2024

Contributor

joshbax189 commented Oct 28, 2024

Minor fix

The repl.start() method was changed a while ago to take either an object arg or a string for the prompt: https://nodejs.org/docs/latest-v20.x/api/repl.html#replstartoptions

This updates the call to match the new API

require('repl').start({
"prompt": '%s',
"ignoreUndefined": true,  // do not print undefined
"preview": true                 // when completing print out the type in a comment
})

Also, the NODE_REPL_MODE var is available in the inner REPL created by repl.start() so it doesn't need to be passed as an arg.

joshbax189 added 2 commits

October 28, 2024 12:54


          repl.start() takes a single object arg

e1347ba


          NODE_REPL_MODE does not need to be set manually

b99d805

redguardtoo merged commit 65a6972 into redguardtoo:master

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet