Add new manage_ec2_instance role #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravesm
reviewed
Nov 22, 2024
hakbailey
reviewed
Nov 22, 2024
tests/integration/targets/test_ec2_instance_create/defaults/main.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/test_ec2_instance_create/tasks/test_ec2_with_igw_sg_eip.yml
Outdated
Show resolved
Hide resolved
roles/ec2_instance_create/tasks/ec2_instance_create_operations.yml
Outdated
Show resolved
Hide resolved
roles/ec2_instance_create/tasks/ec2_instance_create_operations.yml
Outdated
Show resolved
Hide resolved
roles/ec2_instance_create/tasks/ec2_instance_create_operations.yml
Outdated
Show resolved
Hide resolved
abikouo
requested changes
Nov 27, 2024
roles/ec2_instance_create/README.md
Outdated
|
|
||
| ### Role Operation | ||
|
|
||
| * **ec2_instance_create_operation**: (Optional) |
There was a problem hiding this comment.
This should be replaced by the instance state with the values: present, running...
There was a problem hiding this comment.
I left a comment about this but I disagree, for this use case I think we should stick to create and delete.
roles/ec2_instance_create/tasks/ec2_instance_create_operations.yml
Outdated
Show resolved
Hide resolved
hakbailey
reviewed
Dec 2, 2024
roles/ec2_instance_create_delete/tasks/ec2_instance_delete_operations.yml
Outdated
Show resolved
Hide resolved
hakbailey
requested changes
Dec 2, 2024
roles/ec2_instance_create_delete/tasks/ec2_instance_create_operations.yml
Outdated
Show resolved
Hide resolved
roles/ec2_instance_create_delete/tasks/ec2_instance_create_operations.yml
Outdated
Show resolved
Hide resolved
roles/ec2_instance_create_delete/tasks/ec2_instance_delete_operations.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/test_ec2_instance_create_delete/tasks/test_ec2_only.yml
Outdated
Show resolved
Hide resolved
hakbailey
reviewed
Dec 2, 2024
hakbailey
force-pushed
the
ec2-create-instance-role
branch
from
d3bbb9f to
076eade
Compare
GomathiselviS
requested changes
Dec 6, 2024
hakbailey
changed the title
GomathiselviS
approved these changes
Dec 6, 2024
hakbailey
approved these changes
Dec 6, 2024
alinabuzachis
approved these changes
Dec 9, 2024
gravesm
approved these changes
Dec 9, 2024
abikouo
requested changes
Dec 9, 2024
roles/manage_ec2_instance/tasks/ec2_instance_create_operations.yml
Outdated
Show resolved
Hide resolved
roles/manage_ec2_instance/tasks/ec2_instance_create_operations.yml
Outdated
Show resolved
Hide resolved
abikouo
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new role to create a ec2 instance with customizable configuration.
See: https://issues.redhat.com/browse/ACA-1959