Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backstage templates #127

Merged
merged 6 commits into from
Dec 17, 2024
Merged

Conversation

kcagran
Copy link
Contributor

@kcagran kcagran commented Dec 12, 2024

Add backstage templates

justinc1 and others added 2 commits December 12, 2024 13:47
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
@justinc1 justinc1 force-pushed the backstage-templates branch from 9a6a7bf to 852838b Compare December 12, 2024 12:47
@justinc1
Copy link
Contributor

Just tested this, both create and terminate patterns work. I see linter fixes are needed.

This reverts commit ba81f54.
Copy link
Collaborator

@hakbailey hakbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a dev environment where we can test this?

description: AWS region where resources should be created
type: string
ui:options:
rows: 5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with how the backstage templates work, what does rows: 5 do?

Copy link
Contributor Author

@kcagran kcagran Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
type: string
ui:options:
rows: 5
sg_rules:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing we should double check, because I didn't see it tested in the demo video, is that this field correctly handles multiline yaml text, e.g.:

- proto: tcp 
  ports: 80 
  cidr_ip: 0.0.0.0/0

I've verified this works when running the job from AAP, I just want to make sure it also works as expected when launching the job template from RHDH.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested, with port 80, 8080, 22 in the list. Part of AAP job output:

TASK [Get security group rules list from string input] *************************  
ok: [localhost] => {"ansible_facts": {"sg_rules_list": [{"cidr_ip": "0.0.0.0/0", "ports": 80, "proto": "tcp"}, {"cidr_ip": "0.0.0.0/0", "ports": 8080, "proto": "tcp"}, {"cidr_ip": "0.0.0.0/0", "ports": 22, "proto": "tcp"}]}, "changed": false}

It works

…tance.yml

Co-authored-by: Helen Bailey <hakbailey@gmail.com>
@GomathiselviS GomathiselviS dismissed hakbailey’s stale review December 17, 2024 14:52

Dismissing as the functionality has been tested justinc1

@GomathiselviS GomathiselviS merged commit de22d7f into redhat-cop:main Dec 17, 2024
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants