-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backstage templates #127
Backstage templates #127
Conversation
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
9a6a7bf
to
852838b
Compare
Just tested this, both create and terminate patterns work. I see linter fixes are needed. |
This reverts commit ba81f54.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a dev environment where we can test this?
extensions/patterns/configure_ec2/template_rhdh/create_ec2_instance.yml
Outdated
Show resolved
Hide resolved
description: AWS region where resources should be created | ||
type: string | ||
ui:options: | ||
rows: 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super familiar with how the backstage templates work, what does rows: 5
do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://backstage.io/docs/features/software-templates/writing-templates/
This rows: 5 is in all samples.
extensions/patterns/configure_ec2/template_rhdh/terminate_ec2_instance.yml
Outdated
Show resolved
Hide resolved
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
type: string | ||
ui:options: | ||
rows: 5 | ||
sg_rules: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing we should double check, because I didn't see it tested in the demo video, is that this field correctly handles multiline yaml text, e.g.:
- proto: tcp
ports: 80
cidr_ip: 0.0.0.0/0
I've verified this works when running the job from AAP, I just want to make sure it also works as expected when launching the job template from RHDH.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested, with port 80, 8080, 22 in the list. Part of AAP job output:
TASK [Get security group rules list from string input] *************************
ok: [localhost] => {"ansible_facts": {"sg_rules_list": [{"cidr_ip": "0.0.0.0/0", "ports": 80, "proto": "tcp"}, {"cidr_ip": "0.0.0.0/0", "ports": 8080, "proto": "tcp"}, {"cidr_ip": "0.0.0.0/0", "ports": 22, "proto": "tcp"}]}, "changed": false}
It works
extensions/patterns/configure_ec2/template_rhdh/create_ec2_instance.yml
Outdated
Show resolved
Hide resolved
extensions/patterns/configure_ec2/template_rhdh/terminate_ec2_instance.yml
Show resolved
Hide resolved
…tance.yml Co-authored-by: Helen Bailey <hakbailey@gmail.com>
Dismissing as the functionality has been tested justinc1
Add backstage templates