Add security for keypair creation in configure_ec2 pattern #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GomathiselviS
changed the title
hakbailey
reviewed
Dec 12, 2024
extensions/patterns/configure_ec2/playbooks/create_ec2_instance.yml
Outdated
Show resolved
Hide resolved
extensions/patterns/configure_ec2/playbooks/create_ec2_instance.yml
Outdated
Show resolved
Hide resolved
GomathiselviS
changed the title
hakbailey
reviewed
Dec 13, 2024
gravesm
reviewed
Dec 13, 2024
hakbailey
approved these changes
Dec 13, 2024
gravesm
approved these changes
Dec 13, 2024
mandar242
reviewed
Dec 13, 2024
| @@ -4,6 +4,18 @@ | |||
|
|
|||
| This pattern is designed to help get an EC2 instance up and running. | |||
|
|
|||
| To enable SSH access to the EC2 instance from your local machine, you need to do 2 things: | |||
There was a problem hiding this comment.
Suggested change
| To enable SSH access to the EC2 instance from your local machine, you need to do 2 things: | |
| To enable SSH access to the EC2 instance from your local machine, following 2 actions are required: |
mandar242
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer : https://issues.redhat.com/browse/ACA-2059
This PR ensures that private keys to ec2 instances are not available in job logs by default