Not prompted to promote from Dev to Stage or Stage to Prod (input missing)

[murphye]

There doesn't seem to be any "input" commands in the Jenkinsfile. I tried the Spring Boot basic.

[syvanen]

Why would it need that? I personally don't like "input" as CI/CD ideally would run for any commit and shouldn't ideally require any human input from git commit to production deployment.

[pabrahamsson]

I agree with @syvanen here, with proper testing built into your pipeline you probably rather have the promotion and deployments happen without waiting for input.
Feel free to re-open this issue if you like to continue the conversation.

[pcarney8]

@pabrahamsson @syvanen @etsauer In practice removing that input block requires the question, are your tests good enough? and are you disrupting someone else (QA typically) by automatically deploying to Stage?

In this repo, we aren't going to have good, robust tests, nor should we IMO. This repo is for container pipeline examples. I believe omitting a good example of something like an input block is a mistake. We could move it up so it goes from stage to prod. It's easier to delete/comment out the input block than it is to have to search for an example to put it back in. It might be good to add a blue-green with that input block when things go into production (in addition to smoke tests, scaling down and roll back). thoughts?

[etsauer]

@pcarney8 @murphye if you guys believe that there is more value in having an input than not having it, I'm fine having it in. We used to have inputs in our pipelines and ended up removing them because it made testing changes to the repo so much easier. Would it be a good compromise to include input blocks, but leave them commented out, with instructions in the README to enable them if desired?

cc: @syvanen @pabrahamsson

[pabrahamsson]

That's a valid point @pcarney8 so let's add input gates after stage deployment for:

• multi-cluster-spring-boot
• basic-spring-boot

The other pipelines already have input gates and I think the selenium example is one that can do without.