Fix task input syntax #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix the syntax issue during the deploy task.
At the moment, the variables are not interpreted correctly as the task input syntax is incorrect.
See tektoncd for the correct syntax reference. We should use parentheses instead of curly braces.
How should this be tested?
Follow the manual instructions to setup the projects, the tasks, the pipelines...
Start the pipeline and wait for the first task to be completed (build). the deploy task will fail.
The step "oc tag source destination" will fail as the source reference is invalid.
Is there a relevant Issue open for this?
No open issue. I just read the readme and tried it
Who would you like to review this?
cc: @redhat-cop/containers-approvers
cc: @raffaelespazzoli
cc: @sabre1041