Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align app labels with kubernetes recommendations #121

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

etsauer
Copy link
Contributor

@etsauer etsauer commented Apr 13, 2020

What does this PR do?

Align with kubernetes recommended app labels

How should this be tested?

Deploy basic-spring-boot pipeline, and check to make sure all resulting resources have the following labels on them:

      app.kubernetes.io/name:
      app.kubernetes.io/instance:
      app.kubernetes.io/component:
      app.kubernetes.io/part-of:
      app.kubernetes.io/managed-by:

Before we merge, we might want to have a discussion about how we assign values to these.

Is there a relevant Issue open for this?

related to #119

Who would you like to review this?

cc: @redhat-cop/containers-approvers

Copy link
Contributor

@pabrahamsson pabrahamsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @etsauer, LGTM

@pabrahamsson pabrahamsson merged commit 82a03fa into redhat-cop:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants