🌲 FIX - broken selector on service and updated nginx image 🌳

[springdo]

What does this PR do?

Two fixes. Happy to raise a PR for each though ;)

• nginx 112 is deprecated and no longer exists in OpenShift 4.4 so this pipeline will fail. I bumped it to 114
• Since merging Adopt standardized app labels for the basic-nginx app #145 the app=${APPLICATION_NAME} selector was removed so the service connection to the pod is broken. This fixes that by only using the deploymentConfig.

FYI - @etsauer I mentioned this in the Pelorus Dev channel.

How should this be tested?

See README.

Who would you like to review this?

cc: @redhat-cop/containers-approvers

[springdo]

/assign @etsauer

[etsauer]

@springdo the problem with this is that nginx:1.14 doesn't seem to exist in 4.3, so this breaks in that case. I find it odd that from one version to the next, there is no overlap in the tags.

$ oc get clusterversion
NAME      VERSION   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.3.18    True        False         56d     Cluster version is 4.3.18

$ oc get imagestream -n openshift nginx
NAME    IMAGE REPOSITORY                                                                   TAGS               UPDATED
nginx   default-route-openshift-image-registry.apps.d1.casl.rht-labs.com/openshift/nginx   1.10,1.12,latest   4 months ago

[springdo]

@etsauer yup that's annoying alright. I noticed that the image is not in the UI for the registry but you can still pull it.

$ oc get clusterversion
NAME      VERSION   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.4.3     True        False         55d     Cluster version is 4.4.3

$ oc get imagestream -n openshift nginx
NAME    IMAGE REPOSITORY                                                   TAGS               UPDATED
nginx   image-registry.openshift-image-registry.svc:5000/openshift/nginx   1.10,1.14,latest   8 weeks ago

$ docker pull registry.access.redhat.com/rhscl/nginx-112-rhel7
Using default tag: latest
latest: Pulling from rhscl/nginx-112-rhel7
Digest: sha256:3701ac560e3f005b219a7bdfe51c59909c4899ca1a3409f3ac57e7dde9462cdd
Status: Image is up to date for registry.access.redhat.com/rhscl/nginx-112-rhel7:latest
registry.access.redhat.com/rhscl/nginx-112-rhel7:latest

Do you want me to split the PR up so? One for the selector fix and one for the nginx fix so we can at least unbreak the deployment?

[etsauer]

@springdo what if, for now, we include our own imagestream that contains 1.14, so that its available no matter what?

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[springdo]

@etsauer - fyi

[etsauer]

lgtm for now. we'll come back as a followup and make it work for older versions of OCP

[etsauer]

/lgtm /approve

[etsauer]

/approve

[etsauer]

/lgtm

[redhat-cop-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: etsauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [etsauer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment