-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding basic-helm-spring-boot pipeline #153
adding basic-helm-spring-boot pipeline #153
Conversation
/assign @oybed |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
I think having some example Helm pipelines will be helpful for customers looking to adopt Helm. Anyone mind taking a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! A few changes requested
basic-helm-spring-boot/.helm/jenkins-agent-helm/templates/buildconfig.yaml
Outdated
Show resolved
Hide resolved
basic-helm-spring-boot/.helm/jenkins-agent-helm/templates/buildconfig.yaml
Outdated
Show resolved
Hide resolved
basic-helm-spring-boot/.helm/spring-boot/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
oc get route jenkins -o jsonpath='{.spec.host}' | ||
``` | ||
|
||
Then, follow these steps: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to automate these steps (Creating a BuildConfig
that will automatically create the Jenkins job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went with the manual approach since the JenkinsPipeline strategy is deprecated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
heavy quotes on "deprecated". It will not be removed anytime soon
@sabre1041 Updated, and just left you one comment |
basic-helm-spring-boot/.helm/spring-boot/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
2c0e79d
to
e37aad5
Compare
/assign sabre1041 |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pabrahamsson, sabre1041 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
Adds
basic-helm-spring-boot
, which is similar tobasic-spring-boot
except that it uses Helm and Helm charts instead of ansible and the OpenShift applier. Closes #116How should this be tested?
The README I added shows how to configure and run this pipeline, however, since this hasn't been merged in yet, make note of the following changes:
Who would you like to review this?
cc: @redhat-cop/containers-approvers