Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding basic-helm-spring-boot pipeline #153

Merged
merged 3 commits into from
Oct 20, 2020

Conversation

deweya
Copy link
Contributor

@deweya deweya commented Aug 16, 2020

What does this PR do?

Adds basic-helm-spring-boot, which is similar to basic-spring-boot except that it uses Helm and Helm charts instead of ansible and the OpenShift applier. Closes #116

How should this be tested?

The README I added shows how to configure and run this pipeline, however, since this hasn't been merged in yet, make note of the following changes:

Who would you like to review this?

cc: @redhat-cop/containers-approvers

@deweya
Copy link
Contributor Author

deweya commented Aug 16, 2020

/assign @oybed

@stale
Copy link

stale bot commented Oct 16, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Oct 16, 2020
@deweya
Copy link
Contributor Author

deweya commented Oct 16, 2020

I think having some example Helm pipelines will be helpful for customers looking to adopt Helm. Anyone mind taking a look?

Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! A few changes requested

basic-helm-spring-boot/README.md Outdated Show resolved Hide resolved
basic-helm-spring-boot/README.md Outdated Show resolved Hide resolved
basic-helm-spring-boot/README.md Outdated Show resolved Hide resolved
basic-helm-spring-boot/README.md Outdated Show resolved Hide resolved
basic-helm-spring-boot/README.md Outdated Show resolved Hide resolved
oc get route jenkins -o jsonpath='{.spec.host}'
```

Then, follow these steps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to automate these steps (Creating a BuildConfig that will automatically create the Jenkins job

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went with the manual approach since the JenkinsPipeline strategy is deprecated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heavy quotes on "deprecated". It will not be removed anytime soon

basic-helm-spring-boot/README.md Outdated Show resolved Hide resolved
@stale stale bot removed the wontfix label Oct 17, 2020
@deweya
Copy link
Contributor Author

deweya commented Oct 18, 2020

@sabre1041 Updated, and just left you one comment

@deweya deweya force-pushed the feat/helm-pipeline branch 3 times, most recently from 2c0e79d to e37aad5 Compare October 18, 2020 20:22
@oybed
Copy link

oybed commented Oct 18, 2020

/assign sabre1041

@oybed oybed removed their assignment Oct 18, 2020
@sabre1041
Copy link
Contributor

/lgtm

@pabrahamsson
Copy link
Contributor

/approve

@redhat-cop-ci-bot redhat-cop-ci-bot merged commit ca9e5fd into redhat-cop:master Oct 20, 2020
@redhat-cop-ci-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pabrahamsson, sabre1041

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pabrahamsson,sabre1041]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Come up with a structure for a helm-based pipeline
5 participants