Change default service account from 'tekton' to 'pipeline' to match o… #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks good @etsauer left a question inline otherwise good to merge
| @@ -16,7 +16,11 @@ objects: | |||
| annotations: | |||
| description: The web server's http port. | |||
| labels: | |||
| app: ${APPLICATION_NAME} | |||
| app.kubernetes.io/name: ${APPLICATION_NAME} | |||
| app.kubernetes.io/instance: ${APPLICATION_NAME}-build | |||
There was a problem hiding this comment.
Should these be ${APPLICATION_NAME}-deployment in this file?
|
/approve |
pabrahamsson
approved these changes
Sep 18, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pabrahamsson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…penshift pipelines
What does this PR do?
Brief explanation of the code or documentation change you've made
How should this be tested?
Run applier, then kick off pipeline run and make sure it completes.
Is there a relevant Issue open for this?
resolves #149
Who would you like to review this?
cc: @redhat-cop/containers-approvers