Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic spring applier update #40

Merged
merged 5 commits into from
Oct 4, 2018

Conversation

etsauer
Copy link
Contributor

@etsauer etsauer commented Oct 4, 2018

What does this PR do?

Updated the basic spring pipeline to use the openshift applier v2.0.3

How should this be tested?

Follow steps in basic-spring-boot/README.md

Is there a relevant Issue open for this?

resolves #39

Who would you like to review this?

cc: @redhat-cop/containers-approvers

- name: openshift-applier
scm: git
src: https://github.com/redhat-cop/openshift-applier
version: v2.0.2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since v2.0.3 has been out for a couple of weeks, I'd recommend going to that version.

Also, if you are targeting remote hosts, I'd recommend waiting on v2.0.4 (or submit a follow-up PR) as it will contain this PR: redhat-cop/openshift-applier#68

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oybed not planning on targeting remote hosts. updated to 2.0.3

Copy link

@oybed oybed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2. Log into an OpenShift cluster, then run the following command.
```
$ oc login
$ ansible-playbook -i ./applier/inventory/ /path/to/openshift-applier/playbooks/openshift-cluster-seed.yml
$ ansible-playbook -i ./.applier/ galaxy/openshift-applier/playbooks/openshift-cluster-seed.yml
```

At this point you should have 3 projects deployed (`basic-spring-boot-build`, `basic-spring-boot-dev`, `basic-spring-boot-stage`, and `basic-spring-boot-prod`) with our [Spring Rest](https://github.com/redhat-cop/spring-rest) demo application deployed to all 3.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etsauer could be a follow-up PR, but this talks about 3 projects, while in reality it's really 4 projects if you include the -build one ... it will deploy to the 3 (dev, stage, prod).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oybed addressed.

@oybed
Copy link

oybed commented Oct 4, 2018

Tested and found functionality with the openshift-applier v2.0.3 to be working great.

@oybed oybed merged commit a5523c3 into redhat-cop:master Oct 4, 2018
@etsauer etsauer deleted the basic-spring-applier-update branch October 5, 2018 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simple spring boot doesn't work with the latest version of the applier.
2 participants