-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This is a new CICD pipeline based on a blue green deployment using a spring boot web app #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@malacourse for the most part the instructions and templates seem to work. However, at the end of following the instructions here, I only actually have 1 app deployed (green) in production. The README makes no mention of how to utilize the blue-green setup in prod, and it also doesn't look like the route is even pointing to both services.
Looks like maybe there's some work to do there?
blue-green-spring/README.md
Outdated
Run the following commands to instantiate this example. | ||
|
||
``` | ||
cd ./simple-spring-boot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
directory name incorrect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you run the pipeline a second time it will switch to blue. Each time it is ran the route switches from the service to service. I probably need to create two more routes one that always points to blue and one that always points to green. This way the new release can be checked out before the switch over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@malacourse yeah, and I think a little more explanation of how the flow will work is needed in the README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the Pipeline with readme changes and added two more routes. Review when you get a chance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@malacourse the directory name here still doesn't match the directory you're actually creating
@malacourse bump. |
Fixed directory issue. |
thanks @malacourse |
No description provided.