tekton pipeline #87
tekton pipeline #87
Conversation
There was a problem hiding this comment.
@raffaelespazzoli excellent starting point. added some comments
basic-spring-boot-tekton/README.md
Outdated
| This quickstart can be deployed quickly using Ansible. Here are the steps. | ||
|
|
||
| 1. Clone [this repo](https://github.com/redhat-cop/container-pipelines) | ||
| 2. `cd container-pipelines/basic-spring-boot` |
There was a problem hiding this comment.
Should be basic-spring-boot-tekton
| This example demonstrates how to implement a full end-to-end [Tekton](https://tekton.dev/) Pipeline for a Java application in OpenShift Container Platform. This sample demonstrates the following capabilities: | ||
|
|
||
| * Deploying a Tekton pipeline via applier | ||
| * Building an promoting an application with a tekton pipeline |
There was a problem hiding this comment.
@raffaelespazzoli there needs to be a prerequisites section that describes how to install Tekton pipelines into a cluster
There was a problem hiding this comment.
created prerequisite section
basic-spring-boot-tekton/README.md
Outdated
|
|
||
| This pipeline defaults to use our [Spring Boot Demo App](https://github.com/redhat-cop/spring-rest). | ||
|
|
||
| ## Bill of Materials |
There was a problem hiding this comment.
This seems like more of a Prerequisites instead of a Bill of Materials
There was a problem hiding this comment.
consolidated in prerequisite section
basic-spring-boot-tekton/README.md
Outdated
| At this point you should you can run the pipeline by issuing the followinf command: | ||
|
|
||
| ```shell | ||
| tkn pipeline start basic-spring-boot-pipeline -r source=basic-spring-boot-git -s tekton |
There was a problem hiding this comment.
This should be separated into its own section as it is applicable for both the automated and manual setup
There was a problem hiding this comment.
create a separate paragrph
basic-spring-boot-tekton/README.md
Outdated
| At this point you should you can run the pipeline by issuing the followinf command: | ||
|
|
||
| ```shell | ||
| tkn pipeline start basic-spring-boot-pipeline -r source=basic-spring-boot-git -s tekton |
There was a problem hiding this comment.
command should also be:
tkn pipeline start basic-spring-boot-pipeline -r basic-spring-boot=basic-spring-boot-git -s tekton
basic-spring-boot-tekton/README.md
Outdated
|
|
||
| ## Running the pipelines | ||
|
|
||
| Once you have deployed the needed infrastructure either with applier or manually, you should you can run the pipeline by issuing the following command: |
basic-spring-boot-tekton/README.md
Outdated
| Once you have deployed the needed infrastructure either with applier or manually, you should you can run the pipeline by issuing the following command: | ||
|
|
||
| ```shell | ||
| tkn pipeline start basic-spring-boot-pipeline -r basic-spring-boot=basic-spring-boot-git -s tekton |
There was a problem hiding this comment.
Recommend specifying the namespace either by having the user change into the basic-spring-boot-build project (oc project basic-spring-boot-build) or specify -n basic-spring-boot-build in the command
There was a problem hiding this comment.
I also made a mistake in the command i shared to start the pipeline in my first comment:
tkn -n basic-spring-boot-build pipeline start basic-spring-boot-pipeline -r basic-spring-boot-git=basic-spring-boot-git -s tekton
There was a problem hiding this comment.
I did both just in case
What does this PR do?
adds a new pipeline. This is a tekton pipeline. This pipeline deploys the basic-spring-boot app.
I have been tried to reproduce the behavior of the basic-spring-boot app.
Given the limite capabilities available in tekton that was not fully possible in some situations (eg human approval).
This is my first experience with tekotn and probably there is a lot of margin for improvement.
Feedback on this PR is very welcome.
How should this be tested?
readme.md
Is there a relevant Issue open for this?
#80
Who would you like to review this?
cc: @redhat-cop/containers-approvers