Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added role to host global vars to all other roles. Updated tasks tittles to solve issue707. #716

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

ivarmu
Copy link
Contributor

@ivarmu ivarmu commented Oct 20, 2023

What does this PR do?

Solves the Issue #707 and fixes some bogus taks titles in output.
Also fixes many lintering problems.

How should this be tested?

Manual and Automatic tests has been executed.

Is there a relevant Issue open for this?

resolves #707

Other Relevant info, PRs, etc

N/A

@ivarmu
Copy link
Contributor Author

ivarmu commented Oct 20, 2023

I don't understand why I'm getting this lintering error:

roles/global_vars/README.md:25 MD046/code-block-style Code block style [Expected: indented; Actual: fenced]

The code block is written the same way as it is at other roles... and the configuration tells the code blocks to be fenced, not indented:

@ivarmu ivarmu force-pushed the issue707 branch 4 times, most recently from 3a17559 to 87b580b Compare October 31, 2023 14:50
Copy link
Collaborator

@sean-m-sullivan sean-m-sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I've been absent, this looks good, Some of the spaces were style choices, but it makes sense to fix them, Do like the verb/action change and output, and its also taken a while to review.

@sean-m-sullivan sean-m-sullivan merged commit f45b00f into redhat-cop:devel Nov 1, 2023
13 checks passed
@ivarmu ivarmu deleted the issue707 branch March 27, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Names of tasks and docs don't take into account the opportunity to delete objects
2 participants