Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constructed inventory source skip #720

Merged
merged 2 commits into from
Nov 4, 2023

Conversation

sean-m-sullivan
Copy link
Collaborator

What does this PR do?

The role 'inventory_sources' will now skip when the source parameter is constructed. These sources are auto created and not meant to be edited. However they can still be synced with the inventory_source_update.

How should this be tested?

Automated tests

Is there a relevant Issue open for this?

#601

Copy link
Collaborator

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once the tests start working

@sean-m-sullivan sean-m-sullivan force-pushed the constructed_fix branch 2 times, most recently from a7c69f0 to 8929559 Compare November 4, 2023 00:10
@sean-m-sullivan
Copy link
Collaborator Author

Having you reaprove as more changes including some changing our testing, the problem being constructed inventory, and adding new versions of awx.

Copy link
Contributor

@ivarmu ivarmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sean-m-sullivan sean-m-sullivan enabled auto-merge (squash) November 4, 2023 11:27
@sean-m-sullivan sean-m-sullivan merged commit a79f987 into redhat-cop:devel Nov 4, 2023
13 checks passed
Klaas- added a commit to Klaas-/controller_configuration that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants