Fixed roles diff when the roles are provided as a list

[bogdanmuresan]

What does this PR do?

The PR fixes roles diff, when the roles are provided as a list in the "roles" key, and not individually in "role".
All the elements in the compare list need to be expanded once more, for each role in the roles list.

At the moment, when using roles as a list, all the controller_roles are set to state absent.

How should this be tested?

Is there a relevant Issue open for this?

resolves #[number]

Other Relevant info, PRs, etc

[ivarmu]

Why don't adding the role and roles to the already existing for ?

controller_configuration/plugins/lookup/controller_object_diff.py

Lines 247 to 262 in 64b3f62

	for item in compare_list_reduced:
	expanded = False
	dupitems = [
	"target_team",
	"target_teams",
	"job_template",
	"job_templates",
	"workflow",
	"workflows",
	"inventory",
	"inventories",
	"project",
	"projects",
	"credential",
	"credentials",
	]

[bogdanmuresan]

Why don't adding the role and roles to the already existing for ?

controller_configuration/plugins/lookup/controller_object_diff.py

Lines 247 to 262 in 64b3f62

	for item in compare_list_reduced:
	expanded = False
	dupitems = [
	"target_team",
	"target_teams",
	"job_template",
	"job_templates",
	"workflow",
	"workflows",
	"inventory",
	"inventories",
	"project",
	"projects",
	"credential",
	"credentials",
	]

Because roles is another dimension. So assuming we have:

---
controller_roles:
  - team: MYTEAM
    projects:
      - project1
      - project2  
    roles:
     - use
     - update

compare_list_reduced will need to have 4 elements at the end, a combination of the projects with each role:
project1 - use, project1 - update, project 2 - use, project2 - update

I don't think this can be done in the first loop, which expands only the projects. I then need to loop once more through the expanded list and expand again for each role.

I guess I could move dupitems definition above the for, so it's scope also covers the second loop, but I thought it would be better to have them separate.

[ivarmu]

LGTM