Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug with docker version 7.0.0 #744

Merged
merged 4 commits into from
Jan 2, 2024

Conversation

ivarmu
Copy link
Contributor

@ivarmu ivarmu commented Jan 2, 2024

Fixed bug with docker version 7.0.0, which includes the command docker compose as a replacement of docker-compose. See https://github.com/docker/docker-py/issues/3194\#issuecomment-1857356075

What does this PR do?

Adds a workaround to let the CI to work properly meanwhile AWX is updated to use the new docker compose command provided by docker 7.0.0.

Also adds some files to .gitignore

How should this be tested?

The CI process should work as expected.

Is there a relevant Issue open for this?

Other Relevant info, PRs, etc

N/A

@ivarmu
Copy link
Contributor Author

ivarmu commented Jan 2, 2024

@branic , I'm not sure about this error:

FILE: ./README.md
[✖] https://github.com/redhat-cop/controller_configuration/workflows/galaxy-release/badge.svg → Status: 404

22 links checked.

ERROR: 1 dead links found!
[✖] https://github.com/redhat-cop/controller_configuration/workflows/galaxy-release/badge.svg → Status: 404

Blame says you were the last one touching that line... hope you or anyone here have more information about this :-)

@Tompage1994
Copy link
Collaborator

@branic , I'm not sure about this error:

FILE: ./README.md
[✖] https://github.com/redhat-cop/controller_configuration/workflows/galaxy-release/badge.svg → Status: 404

22 links checked.

ERROR: 1 dead links found!
[✖] https://github.com/redhat-cop/controller_configuration/workflows/galaxy-release/badge.svg → Status: 404

Blame says you were the last one touching that line... hope you or anyone here have more information about this :-)

Have found this issue and will fix in separate PR

Thanks for the contribution

@Tompage1994 Tompage1994 merged commit ff3c3ed into redhat-cop:devel Jan 2, 2024
12 of 13 checks passed
@ivarmu ivarmu deleted the fix_ci_docker_7.0.0 branch March 27, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants