Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes filetree_create not exporting constructed inventories when AAP < 2.4. Fixed Organization field check #754

Merged

Conversation

ivarmu
Copy link
Contributor

@ivarmu ivarmu commented Jan 16, 2024

What does this PR do?

Fixes two issues:

  1. Tries to export constructed inventories from Tower and AAP < 2.4
  2. Fails to get organization on inventory sources, when no organization is present.

How should this be tested?

Manually tested.

Is there a relevant Issue open for this?

N/A

Other Relevant info, PRs, etc

N/A

@ivarmu ivarmu requested a review from silvinux January 16, 2024 10:13
Copy link
Contributor

@silvinux silvinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@sean-m-sullivan sean-m-sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sean-m-sullivan sean-m-sullivan merged commit 64d0005 into redhat-cop:devel Jan 17, 2024
12 of 13 checks passed
@ivarmu ivarmu deleted the fixes_filetree_create_2 branch March 27, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants