forcing verbosity to be read as a string, to fix bug #801 #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-m-sullivan
approved these changes
Apr 2, 2024
|
Also tested with enforced defaults, it works as is, as its not being filtered |
|
This does not work when not setting verbosity. You now get an error. I'll raise a PR to fix. CI did break on this (legitimately) so this should not have been merged 😬 |
Tompage1994
added a commit
to Tompage1994/controller_configuration
that referenced
this pull request
Apr 4, 2024
Merged
djdanielsson
pushed a commit
that referenced
this pull request
Apr 4, 2024
djdanielsson
pushed a commit
that referenced
this pull request
Apr 4, 2024
* Fix bug with #802 * Fix issue on all roles where an integer value being set as 0 caused value not to be passed to controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fixes bug where verbosity when set to 0 was being dropped
How should this be tested?
automated
Is there a relevant Issue open for this?
resolves #801
Other Relevant info, PRs, etc