Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding pause loop feature #844

Merged
merged 2 commits into from
Jun 18, 2024
Merged

adding pause loop feature #844

merged 2 commits into from
Jun 18, 2024

Conversation

djdanielsson
Copy link
Collaborator

What does this PR do?

adds a variable to add a pause in the loop for any of the roles to slow it down to allow API not to get overloaded

How should this be tested?

this should manually be tested, which I have not yet.

Is there a relevant Issue open for this?

resolves #832

Other Relevant info, PRs, etc

	modified:   roles/applications/README.md
	modified:   roles/applications/defaults/main.yml
	modified:   roles/applications/tasks/main.yml
	modified:   roles/bulk_host_create/README.md
	modified:   roles/bulk_host_create/defaults/main.yml
	modified:   roles/bulk_host_create/tasks/main.yml
	modified:   roles/bulk_job_launch/README.md
	modified:   roles/bulk_job_launch/defaults/main.yml
	modified:   roles/bulk_job_launch/tasks/main.yml
	modified:   roles/credential_input_sources/README.md
	modified:   roles/credential_input_sources/defaults/main.yml
	modified:   roles/credential_input_sources/tasks/main.yml
	modified:   roles/credential_types/README.md
	modified:   roles/credential_types/defaults/main.yml
	modified:   roles/credential_types/tasks/main.yml
	modified:   roles/credentials/README.md
	modified:   roles/credentials/defaults/main.yml
	modified:   roles/credentials/tasks/main.yml
	modified:   roles/execution_environments/README.md
	modified:   roles/execution_environments/defaults/main.yml
	modified:   roles/execution_environments/tasks/main.yml
	modified:   roles/groups/README.md
	modified:   roles/groups/defaults/main.yml
	modified:   roles/groups/tasks/main.yml
	modified:   roles/hosts/README.md
	modified:   roles/hosts/defaults/main.yml
	modified:   roles/hosts/tasks/main.yml
	modified:   roles/instance_groups/README.md
	modified:   roles/instance_groups/defaults/main.yml
	modified:   roles/instance_groups/tasks/main.yml
	modified:   roles/instances/README.md
	modified:   roles/instances/defaults/main.yml
	modified:   roles/instances/tasks/main.yml
	modified:   roles/inventories/README.md
	modified:   roles/inventories/defaults/main.yml
	modified:   roles/inventories/tasks/main.yml
	modified:   roles/inventory_source_update/README.md
	modified:   roles/inventory_source_update/defaults/main.yml
	modified:   roles/inventory_source_update/tasks/main.yml
	modified:   roles/inventory_sources/README.md
	modified:   roles/inventory_sources/defaults/main.yml
	modified:   roles/inventory_sources/tasks/main.yml
	modified:   roles/job_templates/README.md
	modified:   roles/job_templates/defaults/main.yml
	modified:   roles/job_templates/tasks/main.yml
	modified:   roles/labels/README.md
	modified:   roles/labels/defaults/main.yml
	modified:   roles/labels/tasks/main.yml
	modified:   roles/notification_templates/README.md
	modified:   roles/notification_templates/defaults/main.yml
	modified:   roles/notification_templates/tasks/main.yml
	modified:   roles/organizations/README.md
	modified:   roles/organizations/defaults/main.yml
	modified:   roles/organizations/tasks/main.yml
	modified:   roles/project_update/README.md
	modified:   roles/project_update/defaults/main.yml
	modified:   roles/project_update/tasks/main.yml
	modified:   roles/projects/README.md
	modified:   roles/projects/defaults/main.yml
	modified:   roles/projects/tasks/main.yml
	modified:   roles/roles/README.md
	modified:   roles/roles/defaults/main.yml
	modified:   roles/roles/tasks/main.yml
	modified:   roles/schedules/README.md
	modified:   roles/schedules/defaults/main.yml
	modified:   roles/schedules/tasks/main.yml
	modified:   roles/settings/README.md
	modified:   roles/settings/defaults/main.yml
	modified:   roles/settings/tasks/main.yml
	modified:   roles/teams/README.md
	modified:   roles/teams/defaults/main.yml
	modified:   roles/teams/tasks/main.yml
	modified:   roles/users/README.md
	modified:   roles/users/defaults/main.yml
	modified:   roles/users/tasks/main.yml
	modified:   roles/workflow_job_templates/README.md
	modified:   roles/workflow_job_templates/defaults/main.yml
	modified:   roles/workflow_job_templates/tasks/add_workflows_schema.yml
	modified:   tests/templated_role_example/README.md
Copy link
Collaborator

@Tompage1994 Tompage1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I also haven't tested specifically this but I tested the overall mechanism last week and I'm happy with it.

@dbk-rabel
Copy link
Contributor

Tested the changes. Works fine.

@Tompage1994 Tompage1994 merged commit 3065b56 into redhat-cop:devel Jun 18, 2024
9 of 12 checks passed
@djdanielsson djdanielsson deleted the 832 branch June 18, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating/Updating too many job templates in parallel seems to be too much for controller API
3 participants