Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix approval role permission name in object diff. #880

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

bogdanmuresan
Copy link
Contributor

What does this PR do?

Fix #879

How should this be tested?

Is there a relevant Issue open for this?

resolves #[number]

Other Relevant info, PRs, etc

Copy link
Collaborator

@Tompage1994 Tompage1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djdanielsson
Copy link
Collaborator

if you want to update your branch I will merge this

@bogdanmuresan
Copy link
Contributor Author

if you want to update your branch I will merge this

Done. (rebased on top of devel)

@djdanielsson djdanielsson merged commit 618e677 into redhat-cop:devel Aug 6, 2024
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Approve" value as role name should be "approval" in object diff
3 participants