Add user module and role #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djdanielsson
requested changes
Apr 5, 2024
|
|
||
| # Create EDA Controller user | ||
| - name: Add EDA Controller user | ||
| user: |
There was a problem hiding this comment.
I think we should be able to use FQCN here because it's our own module right?
There was a problem hiding this comment.
We don't tend to because we may end up having two different namespaces. I've commited a change to ignore that on ansible-lint.
It's throwing a false positive here because the user module is a core module which there are extra ansible-lint rules about.
Tompage1994
force-pushed
the
feat/user-module-role
branch
from
0230ab6
to
354da2d
Compare
djdanielsson
approved these changes
Apr 5, 2024
Tompage1994
added a commit
that referenced
this pull request
Apr 5, 2024
This reverts commit e6d4f20.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the user module and its related role
How should this be tested?
CI has been updated
Is there a relevant Issue open for this?
resolves #13
Other Relevant info, PRs, etc