Adds tls_validation option to project module and role #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djdanielsson
requested changes
Apr 22, 2024
roles/project/README.md
Outdated
| @@ -52,6 +52,7 @@ This also speeds up the overall role. | |||
| |`new_name`|""|no|str|Setting this option will change the existing name (looked up via the name field.)| | |||
| |`description`|""|no|str|Description to use for the Project.| | |||
| |`url`|""|yes|str|A URL to a remote archive, such as a Github Release or a build artifact stored in Artifactory and unpacks it into the project path for use. (Alias: scm_url)| | |||
| |`tls_validation`|""|no|bool|Whether the URL should validate using TLS.| | |||
There was a problem hiding this comment.
technically isn't the default true?
There was a problem hiding this comment.
Yes you're correct. Copy/paste error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a missing
tls_validationoption to the project module and role. I've also validated there are currently no mossing API options for other roles (latest AAP 2.4 version)How should this be tested?
CI is updated
Is there a relevant Issue open for this?
resolves #47
Other Relevant info, PRs, etc
CI currently broken. #49 will fix it and could be merged first so it can be run through for this PR