Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readme error #170

Closed
wants to merge 1 commit into from
Closed

Fix readme error #170

wants to merge 1 commit into from

Conversation

Tompage1994
Copy link
Contributor

What does this PR do?

Found an error in the readme.

How should this be tested?

Tested and the example now works

Is there a relevant Issue open for this?

Provide a link to any open issues that describe the problem you are solving.
N/A

Other Relevant info, PRs, etc

Please provide link to other PRs that may be related (blocking, resolves, etc. etc.)

Copy link
Contributor

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djdanielsson
Copy link
Contributor

some checks are failing, not sure if we should ignore those or not

@Tompage1994
Copy link
Contributor Author

Closing because #171 is this actual fix

@Tompage1994 Tompage1994 deleted the Readme-fix branch October 28, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants