Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid to create orgs during drop_diff #504

Merged

Conversation

adonisgarciac
Copy link
Contributor

What does this PR do?

Due to conditional "when: __controller_organizations is defined", if there are not any org to remove, it was sent the controller_organizations variable read from filetree_read. Then, organizations will try to be created during drop_diff process.

With this change, if any org has to be removed, an empty list will be sent for controller_organizations.

Copy link
Collaborator

@sean-m-sullivan sean-m-sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good change to me, But we need to put in a changelog fragment for this as the behavior will change.

Copy link
Contributor

@silvinux silvinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sean-m-sullivan sean-m-sullivan enabled auto-merge (squash) February 16, 2023 17:33
@sean-m-sullivan sean-m-sullivan merged commit def9aec into redhat-cop:devel Feb 16, 2023
@adonisgarciac adonisgarciac deleted the fix_create_org_in_drop branch February 27, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants