Revised enforced defaults #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration into devel
sean-m-sullivan
force-pushed
the
revised_default
branch
from
9016f1a
to
3a045f0
Compare
sean-m-sullivan
force-pushed
the
revised_default
branch
from
3a045f0
to
adaf357
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This removes the lookup plugin from the enforced defaults instead relying on if else. This should simplify things and make it run faster.
How should this be tested?
Automated tests are designed around this change.
Is there a relevant Issue open for this?
resolves #[number]
Other Relevant info, PRs, etc