Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller Schedule: forks, timeout and limit can only be set if template is configured as "prompt on launch" #602

Merged

Conversation

Klaas-
Copy link
Contributor

@Klaas- Klaas- commented May 12, 2023

What does this PR do?

Controller Schedule: forks, timeout and limit can only be set if template is configured as "prompt on launch" for these arguments. This restores the default(omit, true), but maybe it should be default(omit)

How should this be tested?

Create a schedule, do not modify an existing one as this works (guess this is a awx.awx.schedule module or even awx api error)

Is there a relevant Issue open for this?

no

Other Relevant info, PRs, etc

Copy link
Collaborator

@sean-m-sullivan sean-m-sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we are working on moving these to modules.

@sean-m-sullivan sean-m-sullivan merged commit 69b9f45 into redhat-cop:devel Jun 8, 2023
@Klaas- Klaas- deleted the klaas-fix_schedule_creation branch June 8, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants