Fix the diff functionality when using with_present #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -105,6 +105,14 @@ def handle_error(self, **kwargs): | |||
| def warn_callback(self, warning): | |||
| self.display.warning(warning) | |||
|
|
|||
| def create_present_list(self, api_list, compare_list): | |||
There was a problem hiding this comment.
Why are we even passing the api list if we do nothing with it. we should just cut that entire part out.
Rickmarges
force-pushed
the
patch/fix_diff
branch
from
dfa66b7
to
4943eba
Compare
Rickmarges
force-pushed
the
patch/fix_diff
branch
from
4943eba
to
a167e72
Compare
sean-m-sullivan
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The PR extends on the previous PR #613
While testing with
with_present: truewe noticed no items were created when the api does not provide any results.This is a small rework of the diff calculation to also add the
state: presentitems whenever the api is empty.How should this be tested?
There are a few cases to test the behavior of
with_present: trueIn all of these cases the diff functionality works as expected.
Is there a relevant Issue open for this?
Other Relevant info, PRs, etc