Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Org environment fix #672

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Org environment fix #672

merged 4 commits into from
Aug 15, 2023

Conversation

sean-m-sullivan
Copy link
Collaborator

What does this PR do?

bugfixes:

  • Fixed issue with organization role not acceppting default environments option correctly.
  • Fixed issue with licence role not operating properly, when a controller never had credentials provided for subscription lookup. See Role Readme for proper usuage.

Is there a relevant Issue open for this?

#671
#670

Other Relevant info, PRs, etc

#667

@willtome
@jrigglem

Tompage1994
Tompage1994 requested changes Aug 15, 2023
View reviewed changes
roles/license/README.md Outdated Show resolved Hide resolved
roles/license/README.md Outdated Show resolved Hide resolved
@sean-m-sullivan sean-m-sullivan force-pushed the org_environment_fix branch 3 times, most recently from 67567bd to 76b607f Compare August 15, 2023 14:15
Tompage1994
Tompage1994 approved these changes Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@Tompage1994 Tompage1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tompage1994
Tompage1994 requested changes Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@Tompage1994 Tompage1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor points

roles/license/defaults/main.yml Outdated Show resolved Hide resolved
changelogs/fragments/licence_org.yml Show resolved Hide resolved
@sean-m-sullivan sean-m-sullivan force-pushed the org_environment_fix branch 2 times, most recently from 8184811 to 7a486ae Compare August 15, 2023 14:22
silvinux
silvinux reviewed Aug 15, 2023
View reviewed changes
Copy link
Contributor

@silvinux silvinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tompage1994 Tompage1994 enabled auto-merge (squash) August 15, 2023 14:27
djdanielsson
djdanielsson approved these changes Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tompage1994
Copy link
Collaborator

CI broken. Once #674 is merged this can be rebased and tested

@Tompage1994 Tompage1994 merged commit b513a43 into redhat-cop:devel Aug 15, 2023
21 checks passed
@sean-m-sullivan sean-m-sullivan deleted the org_environment_fix branch September 27, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvinux silvinux silvinux left review comments

@djdanielsson djdanielsson djdanielsson approved these changes

@Tompage1994 Tompage1994 Tompage1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sean-m-sullivan @Tompage1994 @silvinux @djdanielsson