Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix adhoc role permission name in object diff. #826

Merged
merged 3 commits into from
May 13, 2024
Merged

Fix adhoc role permission name in object diff. #826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f089b7d
Fix adhoc role permission name in object diff.
May 13, 2024
8da93e4
Update controller_object_diff.py
Tompage1994 May 13, 2024
64ce885
Merge branch 'devel' into fix_object_diff_adhoc_role
Tompage1994 May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelogs/fragments/adhoc_role_name_object_diff.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
bugfixes:
- Fix "adhoc" role permission name in object diff.
...
2 changes: 1 addition & 1 deletion plugins/lookup/controller_object_diff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ def run(self, terms, variables=None, **kwargs):
item.update({"organizations": [item[item["resource_type"]]]})
if item["resource_type"] == "instance_group":
item.update({"instance_groups": [item[item["resource_type"]]]})
item.update({"role": item["name"].lower().replace(" ", "_")})
item.update({"role": item["name"].lower().replace(" ", "_").replace("ad_hoc", "adhoc")})
# Remove the extra fields
item.pop("users")
item.pop("teams")
Expand Down
Loading