Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with incorrectly exported approval role name #876

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

przemkalit
Copy link
Contributor

What does this PR do?

While restoring objects with dispatch, I've encountered an issue: the role approval is called approve in the controller, but the API requires approval. As a result, when the filetree_create exports the roles, it uses the wrong role name. I've added an if statement to check if the role name is approve, and if it is, it uses the approval role name.

How should this be tested?

  1. Create workflow job template.
  2. Assign approve role to team.
  3. Export objects with filetree_create.
  4. Import objects with filetree_read and dispatch.

Is there a relevant Issue open for this?

N/A

Other Relevant info, PRs, etc

N/A

Copy link
Contributor

@ivarmu ivarmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivarmu ivarmu enabled auto-merge (squash) July 23, 2024 12:39
@ivarmu ivarmu merged commit f9f9c40 into redhat-cop:devel Jul 23, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants