Revert "Revert "Renaming to platform variables"" #934
Conversation
This reverts commit 4a380f3.
There was a problem hiding this comment.
Generally happy. @sean-m-sullivan I have a few comments but nothing major
sean-m-sullivan
force-pushed
the
revert-932-revert-928-devel
branch
2 times, most recently
from
ddae653
to
4c78324
Compare
sean-m-sullivan
force-pushed
the
revert-932-revert-928-devel
branch
from
4c78324
to
4fec59a
Compare
.github/workflows/pre-commit.yml
Outdated
| collection_name: controller_configuration | ||
| collection_version: 2.10.0 | ||
| collection_name: aap_configuration | ||
| collection_version: 3.0.0-devel | ||
| collection_repo: https://github.com/redhat-cop/aap_configuration/ | ||
| collection_dependencies: awx.awx |
There was a problem hiding this comment.
can this take a list?
There was a problem hiding this comment.
Not without changing it all I believe
There was a problem hiding this comment.
We will need to make that change to fix the workflows
There was a problem hiding this comment.
Ahh, I see what you're referring to now... (not clear in the GH ui). It does take a space separated list
| collection_dependencies: awx.awx | |
| collection_dependencies: awx.awx ansible.eda ansible.hub |
We would also need ansible.platform but that doesn't seem to be on galaxy so that may not be too helpful
There was a problem hiding this comment.
@sean-m-sullivan I think you're involved with the ansible.platform collection... is it going to be on galaxy? (or am I missing it?)
There was a problem hiding this comment.
I don't think so, we might need to change the workflow stuff but we can work on that later
There was a problem hiding this comment.
It is not AFAIK, I was involved in the initial push of it, but have not been more recently, but it it is my understanding it will not be public.
|
This is now good to go from my perspective |
|
We need to fix all the linting issues etc. before releasing though |
i.e. reopens Sean's #928