che-starter #316: Adding support of attributes in workspace config required for Che 7 support. Adding tests for che 7 / theia stacks

[ibuziuk]

related issue - #316

[ibuziuk]

Workspace creation works just fine with attributes in the workspace config, but there is a problem with the startup. Basically, the following link is used for workspace startup after creation:

{
  "href": "https://che.prod-preview.openshift.io/ibuziuk@redhat.com/che-starter-h7u51",
  "rel": "ide url",
  "method": "GET"
}

However, when I navigate to this URL theia IDE is not shown for some reason, even though workspace is marked as started:

However, when I navigate to the very same workspace from dashboard via https://che.prod-preview.openshift.io/dashboard/#/ide/ibuziuk@redhat.com/che-starter-h7u51 theia IDE is shown without problems:

@l0rd @garagatyi do you think this might be an IDE issue ? any ideas whom should I contact regarding this ?

[l0rd]

Yes I had the same problem when working with chectl. The URL in the response opens a GWT IDE. So I used this regex to get the correct URL.

Anyway it looks to me something that should be fixed upstream.

[garagatyi]

This REST link was added by request from IDE team a long time ago. So, no wonder that it is outdated.

[garagatyi]

By outdated I mean that it is designed to be compatible with the GWT IDE. We didn't think about theia back then

[ashumilova]

Workspace link has only GWT IDE location. From dashboard - we redirect to workspace-loader app and it decides which IDE to load in this method https://github.com/eclipse/che/blob/master/workspace-loader/src/index.ts#L348
So if there is server with type - "ide" (in case of Theia) - then its loaded, otherwise - GWT IDE from workspace links is loaded.
With new flow - really needs to be revised.

[ibuziuk]

@ashumilova @l0rd thanks for clarifications. I have created dedicated issue upstream - eclipse-che/che#12376
will IDE team be able to take it to the next sprint, or should I workaround this situation on che-starter side ?

[ashumilova]

Just a suggestion - maybe send from che-starter not to workspace ide link, but to workspace loader in the format: "workspace-loader/namespace/workspacename" and it will handle the IDEs?

[ibuziuk]

@ashumilova it is not that simple since it would require changes in fabric8-wit / fabric8-ui which are also fall back on the ide url send from che-starter which is than opened in the browser. So, the possible workaround would be similar to what @l0rd suggested in his comment above [1]. However, the ideal solution would be fixing this problem upstream.

[1] #323 (comment)

[ashumilova]

Yes, I mean nearly the same like here:
ideURL.replace(/\/[^/|.]*\/[^/|.]*$/g, '\/dashboard\/#\/ide$&')
but go to "workspace-loader/namespace/workspacename", cause this path "dashboard/#/ide/namespace/workspacename" also redirects to it at the end under the hood.

[ibuziuk]

So, you mean https://che.prod-preview.openshift.io/ibuziuk@redhat.com/che-starter-h7u51 would eventually become https://che.prod-preview.openshift.io/workspace-loader/ibuziuk@redhat.com/che-starter-h7u51 ?

[ashumilova]

No, here are my workspace links:

following the regex transforms ide link https://che.openshift.io/ashumilo/theia-evyv5 to
https://che.openshift.io/dashboard/#/ide/ashumilo/theia-evyv5
I was proposing to change regex, that it will be converting ide link to
https://che.openshift.io/workspace-loader/ashumilo/theia-evyv5

[ashumilova]

Sorry, @ibuziuk , you were right about :
https://che.prod-preview.openshift.io/ibuziuk@redhat.com/che-starter-h7u51
if taken as an example from this comment
it trasnforms to
https://che.prod-preview.openshift.io/workspace-loader/ibuziuk@redhat.com/che-starter-h7u51

that should work