fix: consume generator tool from upstream as an npm package #564
Conversation
Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
There was a problem hiding this comment.
This PR is for crw-2-rhel-8 = 2.12, so as it stands I'm OK with it... though the JIRA says fixversion = 2.11, so we'll need a second PR for the 2.11 branch.
I also don't love that there are only "-dev-" versions in https://www.npmjs.com/package/@eclipse-che/plugin-registry-generator for the 2.11 release, I'd prefer to see a stable release at npmjs. Can we do some 7.yy.z releases in addition to the nightly devs?
We'll need a new Prod Sec exception to be noted about this change, however, as it's a new npm dependency that we build (but which is hosted by 3rd party). https://docs.google.com/document/d/1nw_O1QeG5bg1jfpoSkmABNiCjLpxxc9bSQXXLo8jgJw/edit#heading=h.ttxuwnu2u1jf
How will we ensure we're using the latest correct version of the package in 2.x and 2.11 branches?
Can we add this version dependency into https://github.com/redhat-developer/codeready-workspaces/blob/crw-2-rhel-8/dependencies/VERSION.json and add some build process that pulls the version from there to make sure we build with the correct version?
There was a problem hiding this comment.
Can you collect the version of the generator from a centalized place, eg.,
ECPRG_VER=$(curl -sSLo- https://raw.githubusercontent.com/redhat-developer/codeready-workspaces/crw-2-rhel-8/dependencies/VERSION.json \
| yq -r '.Other["@eclipse-che/plugin-registry-generator"]["2.12"]'); echo $ECPRG_VER
Done. |
@nickboldt I don't think it is good to have hardcoded version in the script. But if we do that, shouldn't we use And it would be better to move that value into the varible in the script. |
Agreed, better to pull the version from https://github.com/redhat-developer/codeready-workspaces/blob/crw-2-rhel-8/dependencies/VERSION.json#L2 That way it'll automatically be updated to 2.13 when we move into the 2.12 branch and update 2.x to a newer future version |
It was the goal. It's just that there was a bug that has been fixed (release script was failing to publish to npmjs) so 7.34.2 should be there when you'll cut it |
use version from json .Version to compute .Other["@eclipse-che/plugin-registry-generator"][$REGISTRY_VERSION]; use local file instead of curling from another project/branch
|
ready to merge in both 2.11 and 2.x branches (change is now the same in both places and can simply compute its version and associated generator version, as long as the VERSION.json file in each branch is kept up to date. |
|
related: eclipse-che/che-plugin-registry#1027 |
Signed-off-by: nickboldt <nboldt@redhat.com>
Signed-off-by: nickboldt <nboldt@redhat.com>
|
Failed -- need to copy VERSION.json from upstream to midstream and move it into the root. redhat-developer/devspaces-images@947db41 Respinning: |
|
Had to do a few more things for this to work, including moving to 0.0.2 version of che-openshift-auth plugin (as the 0.0.1 no longer exists). eclipse-che/che-plugin-registry#1028 |
Signed-off-by: Igor Vinokur ivinokur@redhat.com
What does this PR do?
Consume generator tool from upstream as an npm package
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-1928
Release Notes
Docs PR (if applicable)