Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add devfile.yaml to work with plugin registry #965

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

svor
Copy link
Contributor

@svor svor commented Jun 9, 2023

What does this PR do?

Introduces devfile.yaml with commands that allow to verify changes made in the plugin registry.

It is important to have an access to modify CheCluster definition on OS cluster

Only one extension in the list of the embedded plugin registry:
screenshot-nimbusweb me-2023 06 09-16_30_25

Rresult of the changes:
screenshot-nimbusweb me-2023 06 09-16_32_31

Related issue: eclipse-che/che#22243

Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
Copy link
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 if nothing broke while testing.

I figure if you use that flag, ownership will change to root when built during Brew builds, and if you do so inside DS via devfile, it'll change to whatever value is allowed by non-root container's openshift user.

Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
@svor svor requested a review from SDawley as a code owner July 11, 2023 18:11
@svor svor merged commit b1bebaa into devspaces-3-rhel-8 Jul 13, 2023
5 checks passed
@svor svor deleted the sv-devfile-for-plugins branch July 13, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants