-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support dockerfile base image vulnerability scan #150
Conversation
93132de
to
be0e95c
Compare
@zvigrinberg Could you please take a look at this PR for dockerfile base image scanning? Thanks. This PR depends on the changes of RHEcosystemAppEng/exhort-java-api#96 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xieshenzh in Overall good job
for what concern snyk token, let's either remove it completely ( as snyk integration is discontinued) , or just hide its label and text field ( there is a chance that there will be arrangement and agreement between us and snyk, so once it will happen, we can just toggle the two setVisible method' argument from false to true and that's it, rather than re-insert the code again , you call, either do that or keep snyk text field + label code aside in a topic branch in your fork or in the upstream repository , and in case snyk will do "comeback", then it will be easier to merge it instantly...
In addition, please let QE test this version according to the agreed scenarios , and once we get green light from them, and we removing either way the snyk token text field and label, we're good to go ( you just need to bump version of exhort-java-api to 0.0.7-SNAPSHOT after we'll merge exhort-java-api' Image scanning PR).
src/main/java/org/jboss/tools/intellij/settings/ApiSettingsComponent.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jboss/tools/intellij/settings/ApiSettingsComponent.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jboss/tools/intellij/settings/ApiSettingsComponent.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jboss/tools/intellij/settings/ApiSettingsComponent.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jboss/tools/intellij/settings/ApiSettingsConfigurable.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jboss/tools/intellij/settings/ApiSettingsConfigurable.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jboss/tools/intellij/settings/ApiSettingsState.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jboss/tools/intellij/settings/ApiSettingsConfigurable.java
Outdated
Show resolved
Hide resolved
Thanks @zvigrinberg . I removed the code for snyk, the changes are in a separate commit. We can revert it if we want to support it again in the future. |
@xieshenzh I Couldn't find any usages or references in this PR for the new |
Hi @zvigrinberg , EXHORT_SYFT_IMAGE_SOURCE is used to specify the source from which Syft gets the images. Originally, there are four values (radio buttons) for users to select in the plugin configuration:
Then I figured, the plugin always sends request to the exhort backend, it will not work offline. But this property still exists in the exhort-java-api, in case there are more scenarios to support in the future (e.g. read image from local disk). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM + Approved by QE.
Approved for merge and release.
@xieshenzh : The content looks good to me. |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
@ruromero Could you please merge this PR? Thanks. |
Support scanning base image in dockerfile
Jira: https://issues.redhat.com/browse/APPENG-2253
Changed the RHDA plugin to support IntelliJ 2022.1+, due to breaking changes to the Docker plugin which is required for dockerfile scanning.