fix: Qute template validation breaks when using Gradle #1237

angelozerr · 2023-10-18T09:42:19Z

fix: Qute template validation breaks when using Gradle

src/main/java/com/redhat/devtools/intellij/qute/psi/utils/PsiQuteProjectUtils.java

fbricon · 2023-10-18T10:10:58Z

Doesn't work. When I put a breakpoint on the calling code, to display the value of templateDir, I get these logged, when opening the java class declaring the template:

grute.test : file:/Users/fbricon/Dev/souk/grute/.idea/src/main/resources/templates/
grute.native-test : file:/Users/fbricon/Dev/souk/grute/.idea/src/main/resources/templates/
grute.main : file:///Users/fbricon/Dev/souk/grute/src/main/resources/templates/
grute.integrationTest : file:/Users/fbricon/Dev/souk/grute/.idea/src/main/resources/templates/

grute is the project name. So the real problem is getting the proper module (grute.main)

fbricon · 2023-10-18T13:39:04Z

src/main/java/com/redhat/devtools/intellij/lsp4ij/LSPIJUtils.java

+    public static @NotNull URI toUri(@NotNull Module module) {
+        VirtualFile[] roots = ModuleRootManager.getInstance(module).getContentRoots();
+        if (roots.length > 0) {
+            return toUri(roots[0]);


this is not enough. The generated-sources content root shows up 1st in a myproject.main module

Fixes redhat-developer#1237 Signed-off-by: azerr <azerr@redhat.com>

fbricon · 2023-10-30T16:30:04Z

After moving the file created in the generated source folder to the proper src/main/resources folder, template completion finds stale entries :

fbricon · 2023-10-31T10:22:19Z

Please make sure the gradle test projects use gradle 8.4, like the rest. This will minimize downloads, memory usage and will keep the build as fast as possible

...a/com/redhat/devtools/intellij/qute/psi/internal/java/AbstractQuteTemplateLinkCollector.java

Fixes redhat-developer#1237 Signed-off-by: azerr <azerr@redhat.com>

projects/qute/projects/gradle/qute-quickstart/gradle/wrapper/gradle-wrapper.properties

src/main/java/com/redhat/devtools/intellij/qute/psi/QuteSupportForTemplate.java

src/main/java/com/redhat/devtools/intellij/qute/psi/utils/PsiQuteProjectUtils.java

Fixes redhat-developer#1237 Signed-off-by: azerr <azerr@redhat.com>

src/main/java/com/redhat/devtools/intellij/qute/psi/utils/PsiQuteProjectUtils.java

...a/com/redhat/devtools/intellij/qute/psi/internal/java/AbstractQuteTemplateLinkCollector.java

Fixes redhat-developer#1237 Signed-off-by: azerr <azerr@redhat.com>

sonarcloud · 2023-11-06T18:25:30Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

fbricon · 2023-11-07T09:10:31Z

@angelozerr thanks!

openshift-ci bot added the do-not-merge/work-in-progress label Oct 18, 2023

fbricon reviewed Oct 18, 2023

View reviewed changes

src/main/java/com/redhat/devtools/intellij/qute/psi/utils/PsiQuteProjectUtils.java Outdated Show resolved Hide resolved

angelozerr force-pushed the gradle-qute-fix branch from a0b1764 to e1dc9af Compare October 18, 2023 13:32

fbricon reviewed Oct 18, 2023

View reviewed changes

angelozerr added a commit to angelozerr/intellij-quarkus that referenced this pull request Oct 18, 2023

fix: Qute template validation breaks when using Gradle

b2a9210

Fixes redhat-developer#1237 Signed-off-by: azerr <azerr@redhat.com>

angelozerr force-pushed the gradle-qute-fix branch from e1dc9af to b2a9210 Compare October 18, 2023 15:51

angelozerr added a commit to angelozerr/intellij-quarkus that referenced this pull request Oct 20, 2023

fix: Qute template validation breaks when using Gradle

bb7c0f5

Fixes redhat-developer#1237 Signed-off-by: azerr <azerr@redhat.com>

angelozerr force-pushed the gradle-qute-fix branch from b2a9210 to bb7c0f5 Compare October 20, 2023 09:19

angelozerr mentioned this pull request Oct 20, 2023

fix: WIP let gradle main module find templates #1240

Closed

angelozerr added a commit to angelozerr/intellij-quarkus that referenced this pull request Oct 20, 2023

fix: Qute template validation breaks when using Gradle

b019358

Fixes redhat-developer#1237 Signed-off-by: azerr <azerr@redhat.com>

angelozerr force-pushed the gradle-qute-fix branch from bb7c0f5 to b019358 Compare October 20, 2023 13:45

angelozerr added a commit to angelozerr/intellij-quarkus that referenced this pull request Oct 20, 2023

fix: Qute template validation breaks when using Gradle

043fae7

Fixes redhat-developer#1237 Signed-off-by: azerr <azerr@redhat.com>

angelozerr force-pushed the gradle-qute-fix branch from b019358 to 043fae7 Compare October 20, 2023 18:11

angelozerr added a commit to angelozerr/intellij-quarkus that referenced this pull request Oct 21, 2023

fix: Qute template validation breaks when using Gradle

3283b88

Fixes redhat-developer#1237 Signed-off-by: azerr <azerr@redhat.com>

angelozerr force-pushed the gradle-qute-fix branch from 043fae7 to 3283b88 Compare October 21, 2023 09:22

angelozerr added a commit to angelozerr/intellij-quarkus that referenced this pull request Oct 22, 2023

fix: Qute template validation breaks when using Gradle

7813220

Fixes redhat-developer#1237 Signed-off-by: azerr <azerr@redhat.com>

angelozerr force-pushed the gradle-qute-fix branch from 3283b88 to 7813220 Compare October 22, 2023 06:26

angelozerr added a commit to angelozerr/intellij-quarkus that referenced this pull request Oct 22, 2023

fix: Qute template validation breaks when using Gradle

a136c1a

Fixes redhat-developer#1237 Signed-off-by: azerr <azerr@redhat.com>

angelozerr force-pushed the gradle-qute-fix branch from 7813220 to a136c1a Compare October 22, 2023 08:48

angelozerr added a commit to angelozerr/intellij-quarkus that referenced this pull request Oct 22, 2023

fix: Qute template validation breaks when using Gradle

324e5ba

Fixes redhat-developer#1237 Signed-off-by: azerr <azerr@redhat.com>

angelozerr force-pushed the gradle-qute-fix branch from a136c1a to 324e5ba Compare October 22, 2023 08:57

angelozerr added a commit to angelozerr/intellij-quarkus that referenced this pull request Oct 22, 2023

fix: Qute template validation breaks when using Gradle

074d74d

Fixes redhat-developer#1237 Signed-off-by: azerr <azerr@redhat.com>

angelozerr force-pushed the gradle-qute-fix branch from 324e5ba to 074d74d Compare October 22, 2023 09:03

angelozerr added a commit to angelozerr/intellij-quarkus that referenced this pull request Oct 22, 2023

fix: Qute template validation breaks when using Gradle

054b296

Fixes redhat-developer#1237 Signed-off-by: azerr <azerr@redhat.com>

angelozerr force-pushed the gradle-qute-fix branch from 074d74d to 054b296 Compare October 22, 2023 16:32

angelozerr added a commit to angelozerr/intellij-quarkus that referenced this pull request Oct 22, 2023

fix: Qute template validation breaks when using Gradle

5824e15

Fixes redhat-developer#1237 Signed-off-by: azerr <azerr@redhat.com>

angelozerr force-pushed the gradle-qute-fix branch from 054b296 to 5824e15 Compare October 22, 2023 21:19

angelozerr added a commit to angelozerr/intellij-quarkus that referenced this pull request Oct 22, 2023

fix: Qute template validation breaks when using Gradle

6510c01

Fixes redhat-developer#1237 Signed-off-by: azerr <azerr@redhat.com>

angelozerr force-pushed the gradle-qute-fix branch from 5824e15 to 6510c01 Compare October 22, 2023 22:38

fbricon reviewed Oct 31, 2023

View reviewed changes

...a/com/redhat/devtools/intellij/qute/psi/internal/java/AbstractQuteTemplateLinkCollector.java Outdated Show resolved Hide resolved

angelozerr added a commit to angelozerr/intellij-quarkus that referenced this pull request Nov 3, 2023

fix: Qute template validation breaks when using Gradle

8aa7153

Fixes redhat-developer#1237 Signed-off-by: azerr <azerr@redhat.com>

angelozerr force-pushed the gradle-qute-fix branch from 6510c01 to 8aa7153 Compare November 3, 2023 14:41

angelozerr added a commit to angelozerr/intellij-quarkus that referenced this pull request Nov 3, 2023

fix: Qute template validation breaks when using Gradle

38eebe3

Fixes redhat-developer#1237 Signed-off-by: azerr <azerr@redhat.com>

angelozerr force-pushed the gradle-qute-fix branch from 8aa7153 to 38eebe3 Compare November 3, 2023 14:47

angelozerr added a commit to angelozerr/intellij-quarkus that referenced this pull request Nov 3, 2023

fix: Qute template validation breaks when using Gradle

f7005a9

Fixes redhat-developer#1237 Signed-off-by: azerr <azerr@redhat.com>

angelozerr force-pushed the gradle-qute-fix branch from 38eebe3 to f7005a9 Compare November 3, 2023 15:00

angelozerr added a commit to angelozerr/intellij-quarkus that referenced this pull request Nov 3, 2023

fix: Qute template validation breaks when using Gradle

893288c

Fixes redhat-developer#1237 Signed-off-by: azerr <azerr@redhat.com>

angelozerr force-pushed the gradle-qute-fix branch from f7005a9 to 893288c Compare November 3, 2023 18:32

angelozerr added a commit to angelozerr/intellij-quarkus that referenced this pull request Nov 3, 2023

fix: Qute template validation breaks when using Gradle

b46943f

Fixes redhat-developer#1237 Signed-off-by: azerr <azerr@redhat.com>

angelozerr force-pushed the gradle-qute-fix branch from 893288c to b46943f Compare November 3, 2023 19:09

angelozerr added a commit to angelozerr/intellij-quarkus that referenced this pull request Nov 3, 2023

fix: Qute template validation breaks when using Gradle

2ba842a

Fixes redhat-developer#1237 Signed-off-by: azerr <azerr@redhat.com>

angelozerr force-pushed the gradle-qute-fix branch from b46943f to 2ba842a Compare November 3, 2023 19:17

angelozerr marked this pull request as ready for review November 6, 2023 07:57

openshift-ci bot removed the do-not-merge/work-in-progress label Nov 6, 2023

fbricon reviewed Nov 6, 2023

View reviewed changes

projects/qute/projects/gradle/qute-quickstart/gradle/wrapper/gradle-wrapper.properties Outdated Show resolved Hide resolved

fbricon requested changes Nov 6, 2023

View reviewed changes

src/main/java/com/redhat/devtools/intellij/qute/psi/QuteSupportForTemplate.java Outdated Show resolved Hide resolved

src/main/java/com/redhat/devtools/intellij/qute/psi/utils/PsiQuteProjectUtils.java Outdated Show resolved Hide resolved

angelozerr added a commit to angelozerr/intellij-quarkus that referenced this pull request Nov 6, 2023

fix: Qute template validation breaks when using Gradle

a2cc0b4

Fixes redhat-developer#1237 Signed-off-by: azerr <azerr@redhat.com>

angelozerr force-pushed the gradle-qute-fix branch from 2ba842a to a2cc0b4 Compare November 6, 2023 09:20

fbricon reviewed Nov 6, 2023

View reviewed changes

src/main/java/com/redhat/devtools/intellij/qute/psi/utils/PsiQuteProjectUtils.java Show resolved Hide resolved

fbricon reviewed Nov 6, 2023

View reviewed changes

...a/com/redhat/devtools/intellij/qute/psi/internal/java/AbstractQuteTemplateLinkCollector.java Outdated Show resolved Hide resolved

angelozerr added a commit to angelozerr/intellij-quarkus that referenced this pull request Nov 6, 2023

fix: Qute template validation breaks when using Gradle

a2c4c49

Fixes redhat-developer#1237 Signed-off-by: azerr <azerr@redhat.com>

angelozerr force-pushed the gradle-qute-fix branch from a2cc0b4 to a2c4c49 Compare November 6, 2023 15:30

fix: Qute template validation breaks when using Gradle

5c0bd57

Fixes redhat-developer#1237 Signed-off-by: azerr <azerr@redhat.com>

angelozerr force-pushed the gradle-qute-fix branch from a2c4c49 to 5c0bd57 Compare November 6, 2023 18:25

fbricon merged commit a43144e into redhat-developer:main Nov 7, 2023
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Qute template validation breaks when using Gradle #1237

fix: Qute template validation breaks when using Gradle #1237

angelozerr commented Oct 18, 2023

fbricon commented Oct 18, 2023 •

edited

Loading

fbricon Oct 18, 2023

fbricon commented Oct 30, 2023

fbricon commented Oct 31, 2023

sonarcloud bot commented Nov 6, 2023

fbricon commented Nov 7, 2023

fix: Qute template validation breaks when using Gradle #1237

fix: Qute template validation breaks when using Gradle #1237

Conversation

angelozerr commented Oct 18, 2023

fbricon commented Oct 18, 2023 • edited Loading

fbricon Oct 18, 2023

Choose a reason for hiding this comment

fbricon commented Oct 30, 2023

fbricon commented Oct 31, 2023

sonarcloud bot commented Nov 6, 2023

fbricon commented Nov 7, 2023

fbricon commented Oct 18, 2023 •

edited

Loading