Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to registry-library v1.0.1 to ignore OWNERS files #5712

Merged

Conversation

feloy
Copy link
Contributor

@feloy feloy commented May 4, 2022

What type of PR is this:

/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes devfile/api#840

Result of the commands:

go get github.com/devfile/registry-support/registry-library@21de53798172594993e41d27bba8d5d8cd0eee4d
go mod vendor

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label May 4, 2022
@netlify
Copy link

netlify bot commented May 4, 2022

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 7f32145
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6272a1caf84ed700089b6899

@openshift-ci openshift-ci bot requested review from dharmit and rm3l May 4, 2022 15:54
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odo-robot
Copy link

odo-robot bot commented May 4, 2022

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 4, 2022

Windows Tests (OCP) on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 4, 2022

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 4, 2022

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 4, 2022

Validate Tests on commit finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 4, 2022
@feloy feloy requested review from anandrkskd and removed request for dharmit May 5, 2022 05:39
@anandrkskd
Copy link
Contributor

@feloy could the failure on prow be flake due to network??
Otherwise, /lgtm

@feloy
Copy link
Contributor Author

feloy commented May 5, 2022

@feloy could the failure on prow be flake due to network?? Otherwise, /lgtm

Yes, that seems a network problem:

[odo]  ✗  unable to download devfile: unable to find the registry with name "go"

@feloy
Copy link
Contributor Author

feloy commented May 5, 2022

/override ci/prow/v4.10-integration-e2e
/override ci/prow/unit

Tests are passing on IBM Cloud

@openshift-ci
Copy link

openshift-ci bot commented May 5, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/unit, ci/prow/v4.10-integration-e2e

In response to this:

/override ci/prow/v4.10-integration-e2e
/override ci/prow/unit

Tests are passing on IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented May 5, 2022

/approve

Got 2 LGTM

@openshift-ci
Copy link

openshift-ci bot commented May 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label May 5, 2022
@openshift-merge-robot openshift-merge-robot merged commit f73ae5b into redhat-developer:main May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OWNERS files downloaded as part of a devfile stack
4 participants