Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide default method when extending QuarkusLanguageClientAPI #120

Closed
jeffmaury opened this issue Oct 17, 2019 · 1 comment · Fixed by #123
Closed

Provide default method when extending QuarkusLanguageClientAPI #120

jeffmaury opened this issue Oct 17, 2019 · 1 comment · Fixed by #123
Labels
enhancement New feature or request
Milestone
v0.0.3

Comments

@jeffmaury
Copy link
Member

jeffmaury commented Oct 17, 2019 •
edited
Loading

It would be good for implementers that when a new method is added to the QuarkusLanguageClientAPI, it should be provided as a default method.
Ex: an new interface QuarkusPropertyDefinitionProvider has been added that defines a single getPropertyDefinition method, it could have been defaulted to CompletableFuture.completedFuture(null)
@jeffmaury jeffmaury changed the title Provide default method when extending QuarkusLanguageClient Provide default method when extending QuarkusLanguageClientAPI Oct 17, 2019
@angelozerr
Copy link
Contributor

I agree with you, could you create a PR please.

@angelozerr angelozerr added the enhancement New feature or request label Oct 18, 2019
@angelozerr angelozerr added this to the v0.0.3 milestone Oct 18, 2019
jeffmaury added a commit to jeffmaury/quarkus-ls that referenced this issue Oct 18, 2019
@jeffmaury
Add method to QuarkusLanguageClientAPI is now defaulted
11345f7 
Fixes redhat-developer#120

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
@jeffmaury jeffmaury mentioned this issue Oct 18, 2019
Merged
angelozerr pushed a commit that referenced this issue Oct 18, 2019
@jeffmaury @angelozerr
Add method to QuarkusLanguageClientAPI is now defaulted
cf6d17c 
Fixes #120

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.0.3
Development

Successfully merging a pull request may close this issue.

Add method to QuarkusLanguageClientAPI is now defaulted jeffmaury/quarkus-ls
2 participants
@jeffmaury @angelozerr