Support for textDocument/InlayHint

[angelozerr]

Display the Java type of parameter name as inlay hint.

See inlay hints rendererd with gray background:

[angelozerr]

@FroMage @mkouba @maxandersen do you like this feature? Any ferdback ideas are welcome

[maxandersen]

If that can be done reliably and without slowing down editing I'm all for it. very nice!

[maxandersen]

I assume if type can't be inferred it just don't put any hint?

[angelozerr]

that can be done reliably and without slowing down editing I'm all for it. very nice!

No problem with that. InlayHint belongs to lsp specification. It works like codelens. If the compute of inlay hint takes time the will not be displayed but no problem with slow down

I assume if type can't be inferred it just don't put any hint?

Yes

I will record a demo to show more the inlay hint in action

[angelozerr]

@maxandersen here a little demo:

[maxandersen]

Looks very nice. Awesome!

[angelozerr]

Glad it pleases you!

[mkouba]

No problem with that. InlayHint belongs to lsp specification. It works like codelens. If the compute of inlay hint takes time the will not be displayed but no problem with slow down

So if the type info is not available it will just show nothing and cancel the computation in the background?

[angelozerr]

So if the type info is not available it will just show nothing and cancel the computation in the background?

Yes, you can see this behavior inthe demo when there is item in items where items doesn't exists, so item java type ca,,ot be computed. In this case it displays nothing.

[FroMage]

I like displaying the type on declaration, that makes sense (think var in Java, IDEs do the same). But on usage, when you pass it as parameter, I find it weird, no? Do IDEs do that, normally? I don't think they do.

[angelozerr]

I like displaying the type on declaration, that makes sense (think var in Java, IDEs do the same). But on usage, when you pass it as parameter, I find it weird, no? Do IDEs do that, normally? I don't think they do.

At first there is a settings to show type for method parameter.

Eclipse IDE provides this feature for parameter name (not type):

[angelozerr]

I like displaying the type on declaration, that makes sense (think var in Java, IDEs do the same). But on usage, when you pass it as parameter, I find it weird, no? Do IDEs do that, normally? I don't think they do.

@fbricon @maxandersen @mkouba do you think we should remove display of type for method parameter? Perhaps you would prefer displaying parameter name or nothing?

[mkouba]

Perhaps you would prefer displaying parameter name or nothing?

I'm not sure but I think that displaying the parameter name would be a bit more practical as the param type is validated anyway, or? AFAIK ides show the param names on the left side too.

[angelozerr]

I'm not sure but I think that displaying the parameter name would be a bit more practical as the param type is validated anyway, or? AFAIK ides show the param names on the left side too.

Thanks for your feedback @mkouba !