Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't implement by default custom language client API #870

Closed
angelozerr opened this issue May 22, 2023 · 1 comment · Fixed by #871
Closed

Don't implement by default custom language client API #870

angelozerr opened this issue May 22, 2023 · 1 comment · Fixed by #871
Assignees
@angelozerr
Labels
debt enhancement New feature or request
Milestone
0.15.0

Comments

@angelozerr
Copy link
Contributor

When a LSP client consumes the last version of Qute LS, it doesn't know which new API methods that it needs to implement because all API are implemented by default which return a CompletableFuture.completableFuture(null).

We need to remove default implementation to force all LSP client (like IJ Quarkus, JBoss Tools Quarkus) to implement new methods.

//cc @sbouchet
@angelozerr angelozerr added enhancement New feature or request debt labels May 22, 2023
@angelozerr angelozerr self-assigned this May 22, 2023
@angelozerr angelozerr added this to the 0.15.0 milestone May 22, 2023
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue May 22, 2023
@angelozerr
Don't implement by default custom language client API
be7fc52 
Fixes redhat-developer#870

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue May 22, 2023
@angelozerr
Don't implement by default custom language client API
3081e71 
Fixes redhat-developer#870

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr mentioned this issue May 22, 2023
Merged
datho7561 pushed a commit that referenced this issue May 23, 2023
@angelozerr @datho7561
Don't implement by default custom language client API
5f1490f 
Fixes #870

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr
Copy link
Contributor Author

Thanks so much @datho7561 for your review, I need to do the same thing for MicroProfile LS.

@angelozerr angelozerr mentioned this issue May 23, 2023
Closed
@fbricon fbricon mentioned this issue Jun 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
debt enhancement New feature or request
Projects
IDE Cloudaptors
Archived in project
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

Don't implement by default custom language client API angelozerr/quarkus-ls
1 participant
@angelozerr