Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute - incorrect behavior for nested template records #987

Closed
mkouba opened this issue Aug 28, 2024 · 3 comments · Fixed by #989
Closed

Qute - incorrect behavior for nested template records #987

mkouba opened this issue Aug 28, 2024 · 3 comments · Fixed by #989
Assignees
Labels
bug Something isn't working qute
Milestone

Comments

@mkouba
Copy link
Collaborator

mkouba commented Aug 28, 2024

Expected: a template record that is not annotated with @CheckedTemplate should be treated as if it was annotated with @CheckedTemplate with default values. That is a base path for a nested record should be the simple name of the enclosing class.

Current: IDE expects the base path as if it was a top-level class.

In the following example the template path should be /src/main/resources/templates/HelloResource/Hello.html.

image

@mkouba mkouba added the bug Something isn't working label Aug 28, 2024
@mkouba
Copy link
Collaborator Author

mkouba commented Aug 28, 2024

Also it seems that @CheckedTemplate declared on a nested record is not honored:

image

@angelozerr
Copy link
Contributor

angelozerr commented Aug 28, 2024

Thanks @mkouba for your feedback.

What is the behavior when you define a record outside an inner class?

@mkouba
Copy link
Collaborator Author

mkouba commented Aug 28, 2024

Thanks @mkouba for your feedback.

What is the behavior when you define a record outside an inner class?

It's the same as if you define a top-level class with @CheckedTemplate with default values.

@angelozerr angelozerr self-assigned this Aug 28, 2024
@angelozerr angelozerr modified the milestones: 0.20.0, 0.19.1 Aug 28, 2024
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Aug 29, 2024
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Aug 29, 2024
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Aug 29, 2024
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Aug 29, 2024
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Aug 29, 2024
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Aug 29, 2024
@angelozerr angelozerr modified the milestones: 0.20.0, 0.19.1 Aug 29, 2024
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Aug 29, 2024
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Aug 29, 2024
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working qute
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants