-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter for Java (server) snippet #297
Filter for Java (server) snippet #297
Conversation
To test this PR, open the Remove metrics dependency and replace with openapi dependency in the pom.xml In other words, replace: <dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-smallrye-metrics</artifactId>
</dependency>
with <dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-smallrye-openapi</artifactId>
</dependency> After refreshing, you should see only openapi snippets: @rzgry I had to fix your openapi snippets because some type package was wrong. Please check my fix are OK. |
I need to clean my code and write tests before switching to a real PR. |
af02b9a
to
83a20ad
Compare
...m.redhat.microprofile.ls/src/main/resources/com/redhat/microprofile/snippets/mp-openapi.json
Outdated
Show resolved
Hide resolved
83a20ad
to
389c184
Compare
Works great on my machine. It wasn't a part of this PR but just one small comment so far: Line 106 in 389c184
Please remove the extra space before the last |
f71b085
to
94c8504
Compare
Thanks for the feedback.
fixed. @xorye could you please review my code (javadoc and the README please). |
fb88b10
to
03c1138
Compare
...redhat.microprofile.ls/src/main/java/com/redhat/microprofile/ls/JavaTextDocumentService.java
Outdated
Show resolved
Hide resolved
Also, it looks like |
32f1db4
to
f5e3e55
Compare
Fixes redhat-developer#265 Signed-off-by: azerr <azerr@redhat.com>
Good catch! Fixed. |
Awesome, I'm good with this being merged |
Thanks @xorye for your great feedback. |
Filter for Java (server) snippet
Fixes #265
Signed-off-by: azerr azerr@redhat.com