-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit Datasource snippet #310
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordofthejars
suggested changes
Apr 24, 2020
...edhat.microprofile.ls/src/main/resources/com/redhat/quarkus/snippets/quarkus-properties.json
Outdated
Show resolved
Hide resolved
xorye
commented
Apr 24, 2020
...edhat.microprofile.ls/src/main/resources/com/redhat/quarkus/snippets/quarkus-properties.json
Show resolved
Hide resolved
In my latest push, the |
@fbricon @angelozerr may I merge this? |
fbricon
reviewed
Apr 29, 2020
...edhat.microprofile.ls/src/main/resources/com/redhat/quarkus/snippets/quarkus-properties.json
Outdated
Show resolved
Hide resolved
fbricon
reviewed
Apr 29, 2020
...edhat.microprofile.ls/src/main/resources/com/redhat/quarkus/snippets/quarkus-properties.json
Outdated
Show resolved
Hide resolved
fixed |
fbricon
reviewed
Apr 29, 2020
...edhat.microprofile.ls/src/main/resources/com/redhat/quarkus/snippets/quarkus-properties.json
Outdated
Show resolved
Hide resolved
fbricon
reviewed
Apr 29, 2020
...edhat.microprofile.ls/src/main/resources/com/redhat/quarkus/snippets/quarkus-properties.json
Outdated
Show resolved
Hide resolved
Signed-off-by: David Kwon <dakwon@redhat.com>
fbricon
changed the title
Edit Panache and add Container Image snippets
Edit Datasource snippet
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes redhat-developer/vscode-quarkus#227
To test the Container Image snippet, please try it with a Quarkus project using a recent version of the Qubernetes extension.
Signed-off-by: David Kwon dakwon@redhat.com