Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send project name to the client along with labels. #330

Merged

Conversation

datho7561
Copy link
Contributor

This is useful when presenting the different projects in a menu,
such as in redhat-developer/vscode-quarkus#215.

Signed-off-by: David Thompson davthomp@redhat.com

@datho7561 datho7561 force-pushed the 215-add-extension-project-name branch 5 times, most recently from 7230fa1 to b101ed4 Compare June 30, 2020 15:16
@datho7561 datho7561 marked this pull request as ready for review June 30, 2020 15:29
@datho7561 datho7561 force-pushed the 215-add-extension-project-name branch from b101ed4 to 5e88cac Compare June 30, 2020 17:24
@datho7561
Copy link
Contributor Author

ProjectNameAddingExtensions
Still need to fix the tests, although this use case now works successfully

@datho7561 datho7561 force-pushed the 215-add-extension-project-name branch from 5e88cac to 6b001d9 Compare June 30, 2020 21:10
@angelozerr
Copy link
Contributor

@datho7561 please fix https://travis-ci.org/github/redhat-developer/quarkus-ls/builds/703686845#L1177

It misses .project and .classpath for your new test project (because of .gitignore).

@datho7561 datho7561 force-pushed the 215-add-extension-project-name branch 2 times, most recently from e954000 to 1a60ddb Compare July 2, 2020 15:09
This is useful when presenting the different projects in a menu,
such as in redhat-developer/vscode-quarkus#215.

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 force-pushed the 215-add-extension-project-name branch 2 times, most recently from 09721d0 to 0745b00 Compare July 6, 2020 21:41
Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 force-pushed the 215-add-extension-project-name branch from 0745b00 to e3233f8 Compare July 7, 2020 14:11
@angelozerr angelozerr self-requested a review July 7, 2020 14:17
@fbricon fbricon merged commit 399f30b into redhat-developer:master Jul 7, 2020
@xorye xorye added this to the v0.0.8 milestone Jul 7, 2020
@xorye xorye added the enhancement New feature or request label Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants