Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quarkus.hibernate-orm.database.generation values should be enumerated. #374

Merged
merged 1 commit into from
Dec 9, 2020
Merged

quarkus.hibernate-orm.database.generation values should be enumerated. #374

merged 1 commit into from
Dec 9, 2020

Conversation

rgrunber
Copy link
Member

@rgrunber rgrunber commented Dec 4, 2020 •
edited
Loading

@angelozerr
Copy link
Contributor

@rgrunber I suggest that you see my draft work at master...angelozerr:hibernate-orm

The idea is to have a new static file for hibernate master...angelozerr:hibernate-orm#diff-c62335edaf1084b7a021d479911a314bee47df26ec1687a228551bca1b2ddb24 and the second thing is to add description in the JSON.

@rgrunber
Copy link
Member Author

rgrunber commented Dec 4, 2020

Ah, so a3621e8 is the change you mentioned that allows defining separate static property files. Let's just merge the draft for hibernate-orm statics if it already exists and we can get rid of this one.

@angelozerr
Copy link
Contributor

@rgrunber I would prefer that you do that in order to contribute step by step to quarkus-ls and we need test. Please see this sample https://github.com/redhat-developer/quarkus-ls/blob/master/quarkus.jdt.ext/com.redhat.microprofile.jdt.quarkus.test/src/main/java/com/redhat/microprofile/jdt/quarkus/containerimages/QuarkusContainerImagesTest.java

@rgrunber
Copy link
Member Author

rgrunber commented Dec 4, 2020

@rgrunber I would prefer that you do that in order to contribute step by step to quarkus-ls and we need test. Please see this sample https://github.com/redhat-developer/quarkus-ls/blob/master/quarkus.jdt.ext/com.redhat.microprofile.jdt.quarkus.test/src/main/java/com/redhat/microprofile/jdt/quarkus/containerimages/QuarkusContainerImagesTest.java

Alright, sounds good. I'll make the other changes.

@rgrunber
quarkus.hibernate-orm.database.generation values should be enumerated.
fc356e8 
- Fixes redhat-developer/vscode-quarkus#317
- Add testcase

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@angelozerr angelozerr merged commit 497c13f into redhat-developer:master Dec 9, 2020
@rgrunber rgrunber deleted the fix-317 branch December 9, 2020 15:41
@datho7561 datho7561 added this to the v0.10.0 milestone Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@angelozerr angelozerr

Labels
None yet
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.

quarkus.hibernate-orm.database.generation values should be enumerated
3 participants
@rgrunber @angelozerr @datho7561