Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show validation errors for Qute project without opening a Qute template file #819

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

angelozerr
Copy link
Contributor

@angelozerr angelozerr commented Mar 17, 2023

Show validation errors for Qute project without opening a Qute template file

Fixes #813

This PR requires redhat-developer/vscode-quarkus#597 on vscode side

@angelozerr angelozerr force-pushed the load-qute-project branch 2 times, most recently from 743e338 to 57c36e8 Compare March 17, 2023 18:56
@angelozerr
Copy link
Contributor Author

To test this PR, your workspace need to have a Qute project and you need to close all files. Reopen your vscode and you should see:

  • a progress on the state of the loaf of the Qute project
  • at the end you should see all errors of your project in the Problems view.

I have implemented quickly the LSP progress support. The progress appears on the left of the vscode (and not of the right like Java popup)

Here a demo:

QuteLoadProjectProgress

@angelozerr angelozerr force-pushed the load-qute-project branch 5 times, most recently from 6327382 to f96eea9 Compare March 22, 2023 09:05
@angelozerr angelozerr marked this pull request as ready for review March 22, 2023 09:07
@angelozerr
Copy link
Contributor Author

@JessicaJHee @datho7561 please review this PR and don't forget to use this PR too redhat-developer/vscode-quarkus#597 on vscode side

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested a few different Qute projects that I have on disk, and the progress and reporting Qute errors works with them. It also works properly if I load multiple projects at the same time.

I have one small comment about one of the Javadocs, but I think the PR is good to merge as is. Thanks, Angelo!

* Create a progress.
*
* @param params the progress create parameters
* @return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be help to describe when the completable future resolves

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honnest with you I dont know. I have not understood the lsp progress création which returns a completable future.

@datho7561 datho7561 merged commit 0258d81 into redhat-developer:master Mar 22, 2023
@JessicaJHee
Copy link
Contributor

Oh shoot I didn't realize it's already merged, the comments were mostly optional and the change works well!

@angelozerr
Copy link
Contributor Author

Oh shoot I didn't realize it's already merged, the comments were mostly optional and the change works well!

I will create a little PR to fix your very good review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show validation errors for Qute project without opening a Qute template file
3 participants