-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show validation errors for Qute project without opening a Qute template file #819
Show validation errors for Qute project without opening a Qute template file #819
Conversation
743e338
to
57c36e8
Compare
To test this PR, your workspace need to have a Qute project and you need to close all files. Reopen your vscode and you should see:
I have implemented quickly the LSP progress support. The progress appears on the left of the vscode (and not of the right like Java popup) Here a demo: |
6327382
to
f96eea9
Compare
file Fixes redhat-developer#813 Signed-off-by: azerr <azerr@redhat.com>
@JessicaJHee @datho7561 please review this PR and don't forget to use this PR too redhat-developer/vscode-quarkus#597 on vscode side |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested a few different Qute projects that I have on disk, and the progress and reporting Qute errors works with them. It also works properly if I load multiple projects at the same time.
I have one small comment about one of the Javadocs, but I think the PR is good to merge as is. Thanks, Angelo!
* Create a progress. | ||
* | ||
* @param params the progress create parameters | ||
* @return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be help to describe when the completable future resolves
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honnest with you I dont know. I have not understood the lsp progress création which returns a completable future.
qute.jdt/com.redhat.qute.jdt/src/main/java/com/redhat/qute/jdt/QuteSupportForTemplate.java
Show resolved
Hide resolved
qute.ls/com.redhat.qute.ls/src/main/java/com/redhat/qute/project/QuteProjectRegistry.java
Show resolved
Hide resolved
qute.ls/com.redhat.qute.ls/src/main/java/com/redhat/qute/project/QuteProjectRegistry.java
Show resolved
Hide resolved
Oh shoot I didn't realize it's already merged, the comments were mostly optional and the change works well! |
I will create a little PR to fix your very good review. |
Show validation errors for Qute project without opening a Qute template file
Fixes #813
This PR requires redhat-developer/vscode-quarkus#597 on vscode side