Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DetectVMInstallationsJob.disabled=true property from JDT Debug #898

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

rgrunber
Copy link
Member

@rgrunber rgrunber commented Jul 11, 2023

  • Automatic JVM detection in JDT Debug seems to have introduced a regression in JDT indexing causing java.lang.OutOfMemory
  • Use Eclipse Temurin for JDK distribution.

See eclipse-jdt/eclipse.jdt.debug#231 for (I believe) the root cause.

Note : The property is just a workaround, and will only apply for the tests, so that they can run. I really suspect this would hit people at runtime. I've imported quarkus projects in vscode-quarkus (with vscode-java) and seen the OOM error. 😐

- Automatic JVM detection in JDT Debug seems to have introduced a
  regression in JDT indexing causing java.lang.OutOfMemory
- Use Eclipse Temurin for JDK distribution.

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works locally for me. Thanks, Roland!

@rgrunber rgrunber merged commit dd9791a into redhat-developer:master Jul 11, 2023
1 check passed
@rgrunber rgrunber deleted the fix-oom branch July 11, 2023 20:30
@rgrunber rgrunber added this to the 0.16.0 milestone Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants