-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use newer JDT.LS's JavadocContentAccess2 methods #949
Merged
fbricon
merged 1 commit into
redhat-developer:master
from
fbricon:fix-javadoccontentaccess
Jan 29, 2024
Merged
fix: use newer JDT.LS's JavadocContentAccess2 methods #949
fbricon
merged 1 commit into
redhat-developer:master
from
fbricon:fix-javadoccontentaccess
Jan 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
force-pushed
the
fix-javadoccontentaccess
branch
6 times, most recently
from
January 29, 2024 09:35
295abc6
to
390d7b0
Compare
Plenty of test failures like:
Caused by 2-week old refatoring eclipse-jdt/eclipse.jdt.core@4556ac2#diff-1999f63d81fb3fd59a1d400627b6dc3eb4dab002248a599d172996e909ce007aR104 jdt.core changing method signatures by adding generics, making it binary incompatible with the lsp4mp bits compiled against previous signatures. |
Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon
force-pushed
the
fix-javadoccontentaccess
branch
from
January 29, 2024 11:05
390d7b0
to
7709abe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes javadoc for qute, similar to eclipse/lsp4mp#432.
Related to redhat-developer/vscode-quarkus#638